Review Request: Fix compilation after recent okteta API change

Milian Wolff mail at milianw.de
Wed Jul 13 17:42:08 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101944/#review4698
-----------------------------------------------------------

Ship it!


looks fine to me

- Milian


On July 13, 2011, 12:44 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101944/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 12:44 p.m.)
> 
> 
> Review request for KDevelop and Friedrich W. H. Kossebau.
> 
> 
> Summary
> -------
> 
> Since r1241388 kdevelop no longer compiles. This patch fixes compilation by simply removing the obsolete parameter. Not sure if it hurts to not pass it for older okteta versions (it defaults to 0 widget), or if there should be version checks and conditional code.
> 
> r1241388: [kdesdk/okteta] Changed: remove QWidget parameter from JobManager::executeJob(...)
> 
> 
> Diffs
> -----
> 
>   utils/okteta/oktetadocument.cpp 5ac0311 
> 
> Diff: http://git.reviewboard.kde.org/r/101944/diff
> 
> 
> Testing
> -------
> 
> Compiles with old and new okteta.
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110713/309ff0b8/attachment.html>


More information about the KDevelop-devel mailing list