Review Request: Storing .kdev4 file in a template subdirectory

[Bastian Schmidt]

> On July 6, 2011, 9:41 a.m., Milian Wolff wrote:
> > plugins/appwizard/appwizardplugin.cpp, line 329
> > <http://git.reviewboard.kde.org/r/101853/diff/1/?file=26108#file26108line329>
> >
> >     please add a comment here and explain why this is is required for your case, i.e. copy'n'paste from your description above
> 
> Bastian Schmidt wrote:
>     Loops through the new project directory and tries to detect the first .kdev4 file.
>     If one is found this file will be used. So .kdev4 file can be stored in any subdirectory and the
>     project templates can be more complex.
> 
> Milian Wolff wrote:
>     hehe yes that but I mean you should add it inside the code ;-)

lol,

sorry I'm new at this review board. Now I have clicked the appwizardplugin.cpp link and added the comment.
Was this correct?


- Bastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101853/#review4440
-----------------------------------------------------------


On July 5, 2011, 6:58 a.m., Bastian Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101853/
> -----------------------------------------------------------
> 
> (Updated July 5, 2011, 6:58 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Hi,
> we are using project layouts like this:
> 
> project/
>  - branches/
>    - 0.0.1/
>      - bla.kdev4
>      - src/
>      - ...
>  - trunk/         <- development version
>    - bla.kdev4
>    - src/
>    - ...
> 
> As I created an application template for this layout, I recognized that
> kdevelop expect the .kdev4 file in the project root directory. For new
> projects, with this layout, the root directory is project/trunk/. So I need the
> possibility to store the template .kdev4 file in the trunk directory.
> 
> I apply this feature to kdevplatform/plugins/appwizard/appwizardplugin.cpp. The
> attached patch adds 6 lines to appwizardplugin.cpp.
> 
> Patch Description:
> The patch loops through the new project directory and tries to detect the first
> .kdev4 file. If one is found this file will be used. That's all.
> So I can store a template .kdev4 file in any subdirectory.
> 
> Bastian
> 
> 
> This addresses bug 276744.
>     http://bugs.kde.org/show_bug.cgi?id=276744
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/appwizardplugin.cpp c3ac864 
> 
> Diff: http://git.reviewboard.kde.org/r/101853/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110706/41d8c061/attachment.html>