Review Request: use QVector<Token> in TokenStream instead of custom container code

David Nolden david.nolden.kde at art-master.de
Wed Jul 6 14:53:01 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101865/#review4466
-----------------------------------------------------------

Ship it!


Fine with me.

- David


On July 6, 2011, 12:54 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101865/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 12:54 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> get rid of custom container code in TokenStream and inherit from QVector<Token> instead
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/lexer.h 5f1a083 
>   languages/cpp/parser/lexer.cpp 94bdab2 
> 
> Diff: http://git.reviewboard.kde.org/r/101865/diff
> 
> 
> Testing
> -------
> 
> all unit tests pass
> 
> 
> Thanks,
> 
> Milian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110706/725877ca/attachment.html>


More information about the KDevelop-devel mailing list