Review Request: Fixes build break: CamelCase headers of Okteta/Kasten libs will not be found if installed to other prefix then kdelibs ones

[Friedrich W. H. Kossebau]

> On July 5, 2011, 9:30 p.m., Commit Hook wrote:
> > This review has been submitted with commit 8cdf7e60da01d97e4261265cb91164566254f5d2 by Friedrich W. H. Kossebau to branch master.

Also backport to 4.2 branch pushed now.

Thanks for review, Alex and Milian!


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101852/#review4414
-----------------------------------------------------------


On July 4, 2011, 11:54 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101852/
> -----------------------------------------------------------
> 
> (Updated July 4, 2011, 11:54 p.m.)
> 
> 
> Review request for KDevelop and Giorgos Tsiapaliwkas.
> 
> 
> Summary
> -------
> 
> Building KDevelop failed for those people who had Okteta (+ headers) installed with another prefix than the one of the kdelibs headers: While the macros will return "Yes, found" the compile will fail as the CamelCase headers will not be found, because in none of the include paths.
> Never came around to fix that, but now that Giorgos reminded me of that, here finally a fix for that, by also delivering the include path for the CamelCase headers from the cmake macros to find Okteta/Kasten.
> 
> (Also includes an update of the hint where Okteta is to be found, which is kdesdk since 4.6, and removes a no longer needed kdelibs version check)
> 
> Okay to also backport to 4.2 branch?
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindLibKasten.cmake 2876552 
>   cmake/modules/FindLibOkteta.cmake 0c80168 
>   utils/CMakeLists.txt f7cb4c8 
>   utils/okteta/CMakeLists.txt 2cc7685 
> 
> Diff: http://git.reviewboard.kde.org/r/101852/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110705/4985ffe3/attachment.html>