Review Request: Add grep view history

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100430/#review1017
-----------------------------------------------------------

Ship it!


The patch looks fine. Maybe you should cleanup the whitespace changes, that would be good.

Thanks

- Aleix


On Jan. 21, 2011, 3:28 p.m., Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100430/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2011, 3:28 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add grepview history, allow user to navigate in the last 5 searches.
> And some bugfixes:
> -Added horizontal scrollbar to grepoutputview
> -Fixed grepdialog size problem
> -Fixed wrong text focus when multiple matches occurs on same line
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepdialog.cpp e6e0ca9 
>   plugins/grepview/grepoutputdelegate.cpp ebd155b 
>   plugins/grepview/grepoutputmodel.h b6f46fa 
>   plugins/grepview/grepoutputmodel.cpp 3afa47d 
>   plugins/grepview/grepoutputview.h 4377810 
>   plugins/grepview/grepoutputview.cpp ec0d721 
>   plugins/grepview/grepoutputview.ui ca059e2 
>   plugins/grepview/grepviewplugin.h 5652621 
>   plugins/grepview/grepviewplugin.cpp 9d83d25 
>   plugins/grepview/grepwidget.ui 000549f 
> 
> Diff: http://git.reviewboard.kde.org/r/100430/diff
> 
> 
> Testing
> -------
> 
> Unit test still works
> 
> 
> Thanks,
> 
> Benjamin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110121/1ffe67ba/attachment.html>