Review Request: Add GHNS support for Qt Compressed Help
Benjamin Port
port.benjamin at gmail.com
Tue Jan 18 22:57:12 UTC 2011
> On Jan. 18, 2011, 6:14 p.m., Milian Wolff wrote:
> > awesome work, as usual guys. The only question is: Where do we host that synchroton?
> >
> > And btw: it shows a bug in the documentation plugin: when you install a new .qch file, it will be added to the combo box in the documentation view and it is selected there. but the documentation tool view will still show the contents of the last selected .qch file (for me it was plain Qt). Please fix that as well.
>
> Aleix Pol Gonzalez wrote:
> It will use the KDE synchrotron. We already discussed that with aaron.
>
> Aleix Pol Gonzalez wrote:
> ah and ship-it+1 :)
Ok, I'll merge it when I have KDE synchrotron url
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100422/#review983
-----------------------------------------------------------
On Jan. 18, 2011, 1:52 p.m., Benjamin Port wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100422/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2011, 1:52 p.m.)
>
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> Allow user to get documentation with GHNS.
>
> However the .knsrc file change before merging with master (to use the final synchrotron url)
>
>
> Diffs
> -----
>
> documentation/qthelp/CMakeLists.txt 43603ec
> documentation/qthelp/kdevelop-qthelp.knsrc PRE-CREATION
> documentation/qthelp/qthelp_config_shared.h 157288d
> documentation/qthelp/qthelp_config_shared.cpp 562916f
> documentation/qthelp/qthelpconfig.h e02a26d
> documentation/qthelp/qthelpconfig.cpp 2832caa
> documentation/qthelp/qthelpconfig.ui 7269c80
> documentation/qthelp/qthelpplugin.cpp 320377e
> documentation/qthelp/tests/testqthelpplugin.cpp 9d058a0
>
> Diff: http://git.reviewboard.kde.org/r/100422/diff
>
>
> Testing
> -------
>
> Unit test still works
>
>
> Thanks,
>
> Benjamin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110118/2d930bfd/attachment.html>
More information about the KDevelop-devel
mailing list