Changes to CodeCompletionWorker regarding multithreading

[Milian Wolff]

David Nolden, 17.01.2011:
> Hi, it seems like when CodeCompletionWorker etc. were ported to
> kdevplatform, someone completely broke the multi-threading. The result
> was that for a year now, we are computing all completion items in the
> foreground thread (ouch).

How come this was not noticed before?

> I have fixed this now in kdevplatform and cpp, the other languages
> might need a slight adaption. In case you're overriding
> CodeCompletionWorker::computeCompletions, then you have to make sure
> to match the changed signature of the function you're overriding. The
> few other changes should be self-explanatory from the compiler errors.
> 
> Now the question is, if we want to backport this to KDevelop 4.2. IMO
> the broken multi-threading was a quite serious regression which is
> fixed now. The problem is that we're using multi-threading now where
> it wasn't used before, which might expose multi-threading bugs we
> created within the last year, and which weren't visible without
> multi-threading.

It seems this requires API changes, hence I'm not in favor of backporting this 
now that we are in RC state.

I know, this sucks, but I don't see any other way.

Bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110117/19ff5705/attachment.sig>