Review Request: Adapt okteta plugin (filemanager modification)
Milian Wolff
mail at milianw.de
Sat Jan 15 15:19:51 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100379/#review906
-----------------------------------------------------------
nope, that change is wrong. remove the first conditional and work on url instead of urls().first()!
utils/okteta/oktetaplugin.cpp
<http://git.reviewboard.kde.org/r/100379/#comment768>
remove this conditional
utils/okteta/oktetaplugin.cpp
<http://git.reviewboard.kde.org/r/100379/#comment769>
this must read:
mContextUrls << url;
- Milian
On Jan. 15, 2011, 3:04 p.m., Benjamin Port wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100379/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2011, 3:04 p.m.)
>
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> Adapt okteta plugin (See filemanager modification: http://git.reviewboard.kde.org/r/100378/ )
>
>
> Diffs
> -----
>
> utils/okteta/oktetaplugin.cpp 5abecaf
>
> Diff: http://git.reviewboard.kde.org/r/100379/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110115/4714a94c/attachment.html>
More information about the KDevelop-devel
mailing list