Cpp code completion bugfix and refactor

Olivier JG olivier.jg at gmail.com
Tue Jan 11 14:07:28 UTC 2011


On 01/11/2011 08:20 PM, David Nolden wrote:
> Looks very good, especially all the new tests. Thanks. :-)
>
> I also like the refactoring and added consistency.
>
> I hope all tests pass? If you created new tests that don't pass yet,
> they should be QEXPECT_FAIL (I've seen some comments in the test code
> saying that something is not working right yet). Given the huge amount
> of changes, my only worry is possible (temporary) instability. Maybe
> it would be good if you gave it a test ride for a few days, but in
> general, feel free to commit it to master.
>
> Greetings, David
>
I'll add some QEXPECT_FAIL tomorrow. For now, I've put the patch on the 
reviewboard (I didn't know I had an identity on kde.org :) ).

http://git.reviewboard.kde.org/r/100367/

-Olivier JG




More information about the KDevelop-devel mailing list