Review Request: Fix duplicate brackets insertion when executing completion for a function

David Nolden david.nolden.kde at art-master.de
Sat Jan 8 17:00:11 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100319/#review780
-----------------------------------------------------------

Ship it!


Looks fine

- David


On Jan. 7, 2011, 11:03 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100319/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2011, 11:03 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Having a text 
> 
> 'object.function()'
> 
> and calling completion for it
> 
> 'object.func<complete here>tion()'
> 
> we got
> 
> 'object.function()()'.
> 
> This patch fixes the bug. 
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codecompletion/item.cpp 5fea5fdc7dd6b8ced515c873ad6f07bb5a682400 
> 
> Diff: http://git.reviewboard.kde.org/r/100319/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110108/318ec924/attachment.html>


More information about the KDevelop-devel mailing list