Review Request: Fix file(GLOB) and FILE(GLOB_RECURSE) implementations, add appropriate tests

[Valentyn Pavliuchenko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100283/
-----------------------------------------------------------

(Updated 2011-01-03 16:19:24.688598)


Review request for KDevelop.


Changes
-------

Moved unit test to cmakeprojectvisitortest. Updated test to create files dynamically in the temporary directory. Included non-RELATIVE case to the test.


Summary
-------

Both file(GLOB) and file(GLOB_RECURSE) parsers were fixed to behave as CMake does (reimplemented properly). Added FOLLOW_SYMLINKS parameter to GLOB_RECURSE. Fixed RELATIVE behavior. Added glob expressions support in directory names in the path, as CMake supports it.


Diffs (updated)
-----

  projectmanagers/cmake/parser/cmakeast.h 54a52d0 
  projectmanagers/cmake/parser/cmakeast.cpp 7e40013 
  projectmanagers/cmake/parser/cmakedebugvisitor.cpp 03a0d8c 
  projectmanagers/cmake/parser/cmakeprojectvisitor.h a825d2b 
  projectmanagers/cmake/parser/cmakeprojectvisitor.cpp e2f16d1 
  projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.h b16b16f 
  projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.cpp 638b7d0 

Diff: http://git.reviewboard.kde.org/r/100283/diff


Testing
-------

Done manual testing. Added appropriate unit test. Unit test passed.


Thanks,

Valentyn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110103/2d73439d/attachment.html>