Review Request: Fix file(GLOB) and FILE(GLOB_RECURSE) implementations, add appropriate tests

[Valentyn Pavliuchenko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100283/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

Both file(GLOB) and file(GLOB_RECURSE) parsers were fixed to behave as CMake does (reimplemented properly). Added FOLLOW_SYMLINKS parameter to GLOB_RECURSE. Fixed RELATIVE behavior. Added glob expressions support in directory names in the path, as CMake supports it.


Diffs
-----

  projectmanagers/cmake/tests/cmakeglobtest.cpp PRE-CREATION 
  projectmanagers/cmake/tests/cmakeglobtest.h PRE-CREATION 
  projectmanagers/cmake/tests/CMakeLists.txt 4de0ce0 
  projectmanagers/cmake/parser/cmakeast.h 54a52d0 
  projectmanagers/cmake/parser/cmakeast.cpp 7e40013 
  projectmanagers/cmake/parser/cmakedebugvisitor.cpp 03a0d8c 
  projectmanagers/cmake/parser/cmakeprojectvisitor.h a825d2b 
  projectmanagers/cmake/parser/cmakeprojectvisitor.cpp e2f16d1 
  projectmanagers/cmake/tests/manual/file_glob/1/g.cpp PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/1/h.cpp PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/2/d.cpp PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/CMakeLists.txt PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/GLOB_RECURSE_SOURCES1.var PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/GLOB_RECURSE_SOURCES2.var PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/GLOB_SOURCES1.var PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/GLOB_SOURCES2.var PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/subdir/1/c.cpp PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/subdir/2 PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/subdir/a.cpp PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/subdir/b.cpp PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/subdir1/1 PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/subdir1/e.cpp PRE-CREATION 
  projectmanagers/cmake/tests/manual/file_glob/subdir1/f.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100283/diff


Testing
-------

Done manual testing. Added appropriate unit test. Unit test passed.


Thanks,

Valentyn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110101/ee8b4824/attachment.html>