Review Request: Fix build for kdeprovider tests

Aleix Pol Gonzalez aleixpol at gmail.com
Sat Jan 1 19:02:12 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100277/#review686
-----------------------------------------------------------

Ship it!


It's not a matter of gcc, maybe you use the gold linker?

it makes sense to add it anyway, so plase commit

- Aleix


On 2010-12-31 16:09:43, Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100277/
> -----------------------------------------------------------
> 
> (Updated 2010-12-31 16:09:43)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add missing dependency for QNetworkManager. Without that, the code fails to build with g++-4.5.
> 
> 
> Diffs
> -----
> 
>   providers/kdeprovider/tests/CMakeLists.txt 7ee2e1fd69b3274026991bdbf274624e3697d64a 
> 
> Diff: http://git.reviewboard.kde.org/r/100277/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110101/92994c3f/attachment.html>


More information about the KDevelop-devel mailing list