Review Request: Fix MakeOutput items for cmake builds with relative paths

[Manuel Massing]

> On Feb. 28, 2011, 9:03 p.m., Milian Wolff wrote:
> > Why are you using a QLinkedList? And there is a problem with i18n usage imo:
> > 
> > a) potential_cd -> that does not sound like a string that should be translated, and i18n is only used in one of the two places that is used
> > b) all new i18n strings are missing context, they probably need to be exactly the same as outputted by cmake, or?

I used QLinkedList because 
a) iterators remain valid after element deletion in the list 
b) O(1) deletetion of elements inside the list

It is mainly a precaution for huge projects, where O(n^2) complexity might otherwise  slow things down.


> On Feb. 28, 2011, 9:03 p.m., Milian Wolff wrote:
> > projectbuilders/makebuilder/makeoutputmodel.cpp, line 268
> > <http://git.reviewboard.kde.org/r/100745/diff/4/?file=10302#file10302line268>
> >
> >     why i18n here but not above/below?

Ok, good catch. This is just an internal identifier, so should indeed not be translated. 

I think all the other translations in outputfilters.h could be removed as well, they are only used internally (they are not used for parsing the cmake output,
just human readable identifiers for the current action)


- Manuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100745/#review1714
-----------------------------------------------------------


On Feb. 27, 2011, 4:03 p.m., Manuel Massing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100745/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2011, 4:03 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Fixes MakeOutput items for cmake builds which use relative paths 
> (i.e. cmake projects with CMAKE_USE_RELATIVE_PATHS set to on).
> 
> Previously, errors generated by source files with relativ paths
> were not clickable because MakeOutputModel does not know about
> the directories they are built in.
> 
> Because cmake is not verbose enough to indicate directory changes,
> observes where object files are being built and use these paths
> as search path for urlToFile.
> 
> 
> Diffs
> -----
> 
>   projectbuilders/makebuilder/makeoutputmodel.h 5ac45535a0d6d5496c48631d281e322c7b1b792e 
>   projectbuilders/makebuilder/makeoutputmodel.cpp 09bb72e4621e8033666d6c0c36c1fc34834754a9 
>   projectbuilders/makebuilder/outputfilters.cpp 3b6b806d73375daf85831f734153a5bf4e2293d6 
> 
> Diff: http://git.reviewboard.kde.org/r/100745/diff
> 
> 
> Testing
> -------
> 
> Tested on cmake project with SET(CMAKE_USE_RELATIVE_PATHS ON).
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110228/00c2cbd2/attachment.html>