Review Request: Update CVS plugin.

Milian Wolff mail at milianw.de
Mon Feb 28 20:47:13 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100771/#review1713
-----------------------------------------------------------

Ship it!


looks fine with me, but removes a (still valid?) todo comment - unrelated?


plugins/cvs/cvsplugin.cpp
<http://git.reviewboard.kde.org/r/100771/#comment1413>

    that todo is still valid, or not? this was removed quite often in this patch



plugins/cvs/cvsplugin.cpp
<http://git.reviewboard.kde.org/r/100771/#comment1412>

    



plugins/cvs/cvsplugin.cpp
<http://git.reviewboard.kde.org/r/100771/#comment1414>

    



plugins/cvs/cvsplugin.cpp
<http://git.reviewboard.kde.org/r/100771/#comment1415>

    


- Milian


On Feb. 28, 2011, 2:19 a.m., Andrey Batyiev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100771/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2011, 2:19 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> CVS plugin works incorrectly when first supplied location is directory. This patch fixes it.
> 
> 
> Diffs
> -----
> 
>   plugins/cvs/cvsplugin.h 90a2d4e 
>   plugins/cvs/cvsplugin.cpp 8f00d59 
> 
> Diff: http://git.reviewboard.kde.org/r/100771/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110228/ee3d9cf4/attachment.html>


More information about the KDevelop-devel mailing list