Review Request: Change "There are no differences" dialog from error to information

Milian Wolff mail at milianw.de
Sun Feb 27 16:13:05 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100680/#review1677
-----------------------------------------------------------

Ship it!


branan, please send one of us your patch as created by "git format-patch" and we will integrate it in the next release.

thanks

- Milian


On Feb. 21, 2011, 6:17 a.m., Branan Purvine-Riley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100680/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2011, 6:17 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> When using git "compare to head", I don't think it's an error condition for there to be no changes. Similar operations in other VCS systems should also not display an error. This patch replaces that error dialog with an information dialog.
> 
> 
> Diffs
> -----
> 
>   vcs/vcspluginhelper.cpp d994dddc547e8f9db480502936212c370bb2024f 
> 
> Diff: http://git.reviewboard.kde.org/r/100680/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Branan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110227/d170d2d9/attachment.html>


More information about the KDevelop-devel mailing list