Review Request: Do not perform background parsing when there are projects in state of loading

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100688/#review1657
-----------------------------------------------------------

Ship it!


Looks good. Would be good to also add to the documentation of "projectAboutToBeOpened" etc. signals the actual flow of the signals, eg. : projectAboutToBeOpened [ -> eventually projectOpened, unless loading failed/aborted] -> projectCloseed
Otherwise, some might expect that projectClosed is only emitted for projects where projectOpened was emitted too.

- David


On Feb. 22, 2011, 11:11 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100688/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2011, 11:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> In BackgroundParser, before running actual parsing, check whether there are projects in state of loading. If there are, wait until they are loaded completely. Without this, initially open files may be parsed two times: first as open files, second as members of a project. In the second case the list of include paths may be different, and that may cause some recursive re-parsing. Also differet sets of defines may cause re-parsing, though it wasn't tried.
> 
> 
> Diffs
> -----
> 
>   language/backgroundparser/backgroundparser.h a8a7b06 
>   language/backgroundparser/backgroundparser.cpp 28bdfee 
>   language/editor/modificationrevision.h d1d54ae 
>   shell/project.cpp 7b2bdf6 
>   shell/projectcontroller.cpp 9b6c96f 
>   shell/tests/shelldocumentoperationtest.cpp 99e5855 
> 
> Diff: http://git.reviewboard.kde.org/r/100688/diff
> 
> 
> Testing
> -------
> 
> Initial testing time varies greatly from launch to launch, so could not estimate the influence on average parsing time. However, the worst-case parsing time (when open files are parsed before their projects are loaded and then reparsed) does decrease.
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110226/9b4df44c/attachment.html>