Review Request: Merge CvsJob and DVcsJob: 1/2

Andrey Batyiev batyiev at gmail.com
Fri Feb 25 03:27:01 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100741/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

There are two classes: CvsJob from plugins/cvs and DVcsJob from vcs/dvcs, both of them very similar functionality and in fact DVcsJob is based on CvsJob. Both of them have nothing to do with either DVCSes or CVS, they are just not-so-thin wrapper around KProcess.
This patch ports CvsJob on top of DVcsJob. Next step would be renaming DVcsJob into something more adequate (VcsCliJob for example).


Diffs
-----

  plugins/cvs/cvsjob.h d26f23e 
  plugins/cvs/cvsjob.cpp b1365c5 

Diff: http://git.reviewboard.kde.org/r/100741/diff


Testing
-------


Thanks,

Andrey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110225/d4d89278/attachment.html>


More information about the KDevelop-devel mailing list