Review Request: Shadow build support for QMake

[Julien Desgats]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100734/
-----------------------------------------------------------

(Updated Feb. 24, 2011, 9:47 p.m.)


Review request for KDevelop.


Changes
-------

Added todo about cache


Summary (updated)
-------

This adds support of shadow builds in QMake plugin, made on CMake model. Currently it does :
    * Adds a configuration dialog at project creation/import
    * Adds support for multiple build configurations (with the same options as config dialog)
    * Make a particular folder/target (needs some more work)
    * Search for .qmake.cache file from build directory instead of sources

Known issues:
    * Some directories and targets does not build on complex projects (this is note directly related on shadow build, is issue is already present on master)
    * Data validation in project properties have a weird behavior : if data is invalid, it's not saved but dialog is closed anyway. This is related to KCModule and I can't find a solution to keep dialog open after a click on Ok.

Todo List (can be done later)
    * Add parsing QMake command line arguments
    * May be use .qmake.cache files instead of command line arguments (like cmake)


Diffs
-----

  CMakeLists.txt d01acd1 
  kdevqmakemanager.desktop 03ca19f 
  qmake.kdev4 8d796ec 
  qmakebuilddirchooser.h PRE-CREATION 
  qmakebuilddirchooser.cpp PRE-CREATION 
  qmakebuilddirchooser.ui PRE-CREATION 
  qmakebuilddirchooserdialog.h PRE-CREATION 
  qmakebuilddirchooserdialog.cpp PRE-CREATION 
  qmakebuilder/CMakeLists.txt 6790d1a 
  qmakebuilder/kdevqmakebuilder.desktop 07391df 
  qmakebuilder/qmakebuilderconfig.kcfg bc1b059 
  qmakebuilder/qmakebuilderpreferences.h a39d446 
  qmakebuilder/qmakebuilderpreferences.cpp d8cc507 
  qmakebuilder/qmakeconfig.ui 2464c19 
  qmakeconfig.h PRE-CREATION 
  qmakeconfig.cpp PRE-CREATION 
  qmakejob.h b00ccf2 
  qmakejob.cpp cfae954 
  qmakemanager.h ede1e30 
  qmakemanager.cpp e0e7042 
  qmakeprojectfile.h d0fb1a9 
  qmakeprojectfile.cpp 8f1b53d 
  tests/CMakeLists.txt 80253bc 
  tests/manual/basic_project/.kdev4/basic_project.kdev4 PRE-CREATION 
  tests/manual/basic_project/basic_project.kdev4 PRE-CREATION 
  tests/manual/basic_project/basic_project.pro PRE-CREATION 
  tests/manual/basic_project/main.cpp PRE-CREATION 
  tests/manual/basic_project/mainwindow.ui PRE-CREATION 
  tests/manual/subdirs_project/.kdev4/subdirs_project.kdev4 PRE-CREATION 
  tests/manual/subdirs_project/dir_a/dir_a.pro PRE-CREATION 
  tests/manual/subdirs_project/dir_a/main.cpp PRE-CREATION 
  tests/manual/subdirs_project/dir_b/dir_b.pro PRE-CREATION 
  tests/manual/subdirs_project/dir_b/main.cpp PRE-CREATION 
  tests/manual/subdirs_project/main.cpp PRE-CREATION 
  tests/manual/subdirs_project/subdirs_project.kdev4 PRE-CREATION 
  tests/manual/subdirs_project/subdirs_project.pro PRE-CREATION 
  tests/test_qmakeproject.h PRE-CREATION 
  tests/test_qmakeproject.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100734/diff


Testing
-------

Correctness of build directory is unit-tested.
Test has been done on several simple to complex projects (QtCreator) : except on the cases listed previously, running QMake or Make works well.


Thanks,

Julien

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110224/3653f2dd/attachment.html>