Review Request: Not possible to select a project target in the "configure launches dialogue"

Dmitry Risenberg dmitry.risenberg at gmail.com
Tue Feb 22 23:29:12 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100692/#review1596
-----------------------------------------------------------

Ship it!


Looks good to me.

It would be even better if the value in an inactive box was not cleared on closing the config dialog, so that it could be restored by selecting the corresponding radio.

- Dmitry


On Feb. 20, 2011, 12:28 p.m., Gerhard Stengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100692/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2011, 12:28 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> There are two problems in the configure launches dialogue which are addressed by this fix
> 
> - the radio button left of the project target dropdown box isn't visible
> - after you've entered a program name in the textbox next to "executable", closed the launch config dialogue and reopen it, it's no longer 
> possible to select a project target again because the dropdown box stays empty. You have to close the dialogue and 
> reopen it.
> 
> 
> Diffs
> -----
> 
>   plugins/execute/nativeappconfig.cpp b8520e0 
>   plugins/execute/nativeappconfig.ui 51d53a4 
> 
> Diff: http://git.reviewboard.kde.org/r/100692/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gerhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110222/8104d6eb/attachment.html>


More information about the KDevelop-devel mailing list