Review Request: MakeBuilder: check that folder really exist before starting process

[Julien Desgats]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100703/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

This is a small patch which do some more tests on MakeBuilder, in particular it checks that given folder really exists and displays a more precise error message. Current implementation tries to set current dir of make process without any check, which is apparently a noop if folder does not exist, so process is not started in the right directory.

By the way, if an error occurs, message is displayed twice, that's because KDevelop::RunController::registerJob is executed twice :
  * when job is created (in ProjectManagerViewPlugin::buildItemsFromContextMenu)
  * when job is started, it re-register itself ! (in BuilderJob::start)
I have a limited knowledge of KCompositeJob, so I didn't push investigations further. Any clues about that, may be I could fix it too.


Diffs
-----

  projectbuilders/makebuilder/makejob.cpp 72fd40e 

Diff: http://git.reviewboard.kde.org/r/100703/diff


Testing
-------


Thanks,

Julien

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110221/e66a917a/attachment.html>