Review Request: Change "There are no differences" dialog from error to information

Olivier Jean de Gaalon olivier.jg at gmail.com
Sat Feb 19 03:37:26 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100680/#review1498
-----------------------------------------------------------

Ship it!


I agree.

- Olivier Jean de


On Feb. 18, 2011, 8:44 p.m., Branan Purvine-Riley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100680/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2011, 8:44 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> When using git "compare to head", I don't think it's an error condition for there to be no changes. Similar operations in other VCS systems should also not display an error. This patch replaces that error dialog with an information dialog.
> 
> 
> Diffs
> -----
> 
>   vcs/vcspluginhelper.cpp d994ddd 
> 
> Diff: http://git.reviewboard.kde.org/r/100680/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Branan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110219/b474222d/attachment.html>


More information about the KDevelop-devel mailing list