Review Request: Add ability to get data from stderr of DVcsJob.

Andrey Batyiev batyiev at gmail.com
Thu Feb 17 22:09:26 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100673/
-----------------------------------------------------------

(Updated Feb. 17, 2011, 10:09 p.m.)


Review request for KDevelop.


Changes
-------

Fixed to work with GitCloneJob.
Extra small fix is for string extraction (start variable points to pre-last '\n'). OK or it should be in separate patch?


Summary
-------

When some operation fails, command-line tools sometimes put information into stderr. Failures could be recoverable, and it's crucial to VCS plugin to known output from stderr. This patch adds this ability.
Consider:
1. I've it separate from stdout. This prevents any unwanted breakage in existing plugins and allows to separate data streams.
2. This changes interface (but not breaks it).


Diffs (updated)
-----

  plugins/git/gitclonejob.h c120b80 
  plugins/git/gitclonejob.cpp 6b54c6b 
  vcs/dvcs/dvcsjob.h e0e29ca 
  vcs/dvcs/dvcsjob.cpp 92c7168 

Diff: http://git.reviewboard.kde.org/r/100673/diff


Testing
-------


Thanks,

Andrey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110217/27fcb758/attachment.html>


More information about the KDevelop-devel mailing list