Review Request: Add ability to get data from stderr of DVcsJob.

[Andrey Batyiev]

> On Feb. 17, 2011, 9:27 a.m., Milian Wolff wrote:
> > vcs/dvcs/dvcsjob.cpp, line 228
> > <http://git.reviewboard.kde.org/r/100673/diff/1/?file=9404#file9404line228>
> >
> >     this looks like existing plugins need to be adapted, to save their stderr to the new d->errorOutput, right? We need to patch them accordingly once this gets merged.
> >     
> >     I don't really understand one thing though: Was this working before? Why does it not work for you? You want to read the stderr in your plugin and -if possible- handle it gracefully? Sounds useful.

The only current in-tree user of DVcsJob is GitPlugin. It just doesn't use data from stderr. Other plugins use their own methods to run tools: subversion use some weird stuff and cvs uses CvsJob, which in turn is very similar to DVcsJob (looks like merge is possible).
It was working before because nobody cared about showing error feedback to user.


- Andrey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100673/#review1471
-----------------------------------------------------------


On Feb. 17, 2011, 1:02 a.m., Andrey Batyiev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100673/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2011, 1:02 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> When some operation fails, command-line tools sometimes put information into stderr. Failures could be recoverable, and it's crucial to VCS plugin to known output from stderr. This patch adds this ability.
> Consider:
> 1. I've it separate from stdout. This prevents any unwanted breakage in existing plugins and allows to separate data streams.
> 2. This changes interface (but not breaks it).
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/dvcsjob.h e0e29ca 
>   vcs/dvcs/dvcsjob.cpp 92c7168 
> 
> Diff: http://git.reviewboard.kde.org/r/100673/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110217/7c2312b4/attachment.html>