Review Request: Fix incomplete redrawing of a toolview

[Dmitry Risenberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100616/
-----------------------------------------------------------

(Updated Feb. 16, 2011, 9:31 p.m.)


Review request for KDevelop.


Changes
-------

Fixed to work correctly with top/bottom dock.

There is a lesser problem still - the bottom dock gets resized during initialization and becomes too narrow. I think the code needs to know somehow that it is in initialization state and not do any resizing at all in this case. Can anyone with knowledge of Subline tell me how to achieve this?


Summary
-------

Fix a bug with incomplete redrawing of a toolview:
0. Assume "Documents" and "Projects" are both on the left.
1. Click on "Documents" tool.
2. Resize it to minimal width.
3. Click on the "Projects" tool and see a border not redrawn.

Reusing IdealMainLayout::resizeWidget didn't work, because this gets called on initialization when min/max constrains are computed wrong.


Diffs (updated)
-----

  sublime/ideal.cpp ad895619e18a16edc74372fa6135647173dbf35f 
  sublime/ideallayout.h 308b4efbfbc74070ae482ed965ceb1040c02f236 
  sublime/ideallayout.cpp f7b3d25dfa6be9195d5de2297b94fa902e1e35a2 

Diff: http://git.reviewboard.kde.org/r/100616/diff


Testing
-------


Thanks,

Dmitry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110216/acc5b2ad/attachment.html>