Review Request: Fix VcsEventModel::addEvents and VcsItemEventModel::addItemEvents.

Andrey Batyiev batyiev at gmail.com
Tue Feb 15 14:58:04 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100662/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

There is a bug when user calls them (VcsEventModel::addEvents and VcsItemEventModel::addItemEvents) for a first time: inserted items have numbers from 0 to list.count()-1, not just list.count().
(Example: list.count() = 5, items is 0,1,2,3,4).
This produces extra empty lines in table views while viewing VCS History window.


Diffs
-----

  vcs/models/vcseventmodel.cpp 865faec 
  vcs/models/vcsitemeventmodel.cpp fe39899 

Diff: http://git.reviewboard.kde.org/r/100662/diff


Testing
-------


Thanks,

Andrey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110215/c8880776/attachment.html>


More information about the KDevelop-devel mailing list