Review Request: Added ability to save restore splitter state in the ProjectManagerView

[David Nolden]

> On Feb. 6, 2011, 9:11 a.m., Milian Wolff wrote:
> > while I think we should integrate this, I have to say it's not the technical correct approach. The thing is that it's - theoretically - possible for users to add the project manager toolview multiple times and you only save one setting...
> > 
> > Sadly, the "right" fix would mean some more changes, adding the proper API to the plugin view interface etc...
> 
> Andreas Pakulat wrote:
>     Yeah, we should probably post this somewhere public as a hack though as there are quite some people annoyed by the inability of storing. And the part about the different stretch-factors for treeview vs. buildset really makes sense these days, the project-buildset widget is not necessary that much anymore.

Well, better save _one_ setting, instead of saving none at all. Since the contents of the project selection is equal in all areas, it's arguable anyway whether it makes sense to store splitter positions separately. The only case where it seems to make sense is when the project view is added at different positions (eg. at bottom rather than left).


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100584/#review1255
-----------------------------------------------------------


On Feb. 6, 2011, 9 a.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100584/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2011, 9 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Currently ProjectTreeView and ProjectBuildSet widgets have the same size while the first one usually contains much more items then the second one. Every time when I run kdevelop I adjust the splitter position and then start to work. This patch allows to save the sate of the QSplitter in the ProjectManagerView widget in a session and restore it next time you open this session.
> 
> I've also added defalt strech factors in order to have 75% for the ProjectTreeView and 25% for the ProjectBuildSet for a new sessions.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/projectmanagerview.cpp 1149282 
> 
> Diff: http://git.reviewboard.kde.org/r/100584/diff
> 
> 
> Testing
> -------
> 
> The following things are tested manually:
>   1 New session have correct splitter position (75%:25%).
>   2 Splitter position is saved restored correctly for different sessions.
>   3 Sessions created before this patch are loaded correctly and splitter position is set to the default value.
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110206/a05fab1c/attachment.html>