Review Request: Run GDB inside shell bug fix

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100509/#review1242
-----------------------------------------------------------

Ship it!


looks good, can you send it to me as outputted by "git format-patch" please?


debuggers/gdb/gdb.cpp
<http://git.reviewboard.kde.org/r/100509/#comment1041>

    think about using KSell::splitArgs here just to make sure
    
    http://api.kde.org/4.2-api/kdelibs-apidocs/kdecore/html/namespaceKShell.html#8d7c7dda510b29a6dfd7834a93f0a369



debuggers/gdb/gdb.cpp
<http://git.reviewboard.kde.org/r/100509/#comment1040>

    merge that with the debug output above imo:
    
    kDebug(9012) << "have shell:" << shellUrl.url() << shell;
    
    or similar. also "\n" is not required when using kDebug (the old code is wrong there).


- Milian


On Feb. 1, 2011, 2:48 p.m., Pauli Sundberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100509/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2011, 2:48 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Kdevelop 4.2 branch debug launcher debugger shell was not working. It gave error:
> "Could not locate the debugging shell 'file:///home/sundberg/eigenor/systemio/trunk/debug/libtool%20--mode=execute'."
> 
> when inputted to dialog was:
> /home/sundberg/eigenor/systemio/trunk/debug/libtool  --mode=execute
> 
> This patch does not solve libtool issue, though the shell seems to be working.
> 
> From output:
> 
> kdevelop(2680)/kdevelop (gdb debugger) GDBDebugger::GDB::start: Starting shell by:  "'/home/sundberg/eigenor/systemio/trunk/debug/libtool --mode=execute' gdb --interpreter=mi2 -quiet"
> 
> Where do those extra ' come around the shell? Though the shell is started properly.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/gdb.cpp 02e23fa 
> 
> Diff: http://git.reviewboard.kde.org/r/100509/diff
> 
> 
> Testing
> -------
> 
> Checked that debugger started properly.
> 
> 
> Thanks,
> 
> Pauli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110205/c0e66e2b/attachment.html>