Review Request: Fix compiling of quanta master

Florian Zumkeller-Quast branleb at
Fri Dec 23 22:07:36 UTC 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 23, 2011, 10:07 p.m.)

Review request for KDevelop and Quanta.


Patch created by git format-patch


Since the last changes of ISourceFormatter from KDevPlatform Quanta was broken and did not compile.
This patch fixes the compiling issues by changing phpformatterplugin and xmlformatterplugin to the new interface of ISourceFormatter.

During the testing it looked to me that there are two different options storing the indentation value for a formatter:
"INDENT" and "indent_size". Because only the latter contained a non-zero value, i changed the behaviour to use the latter one.


  languages/xml/formatter/formatterplugin.h dbe183a 
  languages/xml/formatter/formatterplugin.cpp 4e62a1e 
  plugins/phpformatter/formatterplugin.h 6dc7028 
  plugins/phpformatter/formatterplugin.cpp f1ca6fd 




Florian Zumkeller-Quast

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list