Review Request: Hide _darcs directory tree from kdevelop projects

[Filip Brcic]

> On Dec. 27, 2011, 10:54 a.m., Aleix Pol Gonzalez wrote:
> > Frankly, it's a pity that they use _darcs instead of .darcs. That would make much more sense... But oh well.
> > 
> > I'd prefer to have a more generic fix to that problem, though. Maybe you can look into it? Otherwise we can add this, but if some other weird vcs appear, we'll want to exclude it from the project too.

Agreed. There is even a TODO saying "///@todo This filter should be configurable, and filtering should be done on a manager-independent level"

Maybe a config item like this:

https://photos-1.dropbox.com/i/l/U4n7IjtaSj_UAIvvBq-4YimpjNqwNhwS2DbsO2dDMwM/844580/1325073600/2ca3a43/config_projects_w_ignored_files.png

would help (this is a mockup, btw). Then with the stringlist of filtered files, the filterFiles function could do it's job better. Then either the function should become a member of the class, or should take the filter stringlist as an argument (it is used only once, so either way is okay).

If you believe this to be a good way to filter files more generically, then I'll implement it ASAP.

Of course, this still wouldn't be "manager-independent" filtering, but not even the file list is manager independent, even if cmake pm uses regular QDir to get project files.


- Filip


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103549/#review9296
-----------------------------------------------------------


On Dec. 26, 2011, 11:44 p.m., Filip Brcic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103549/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2011, 11:44 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I recently worked on a C++ project that was using a darcs repository (Darcs is a distributed VCS, for more info visit darcs.net). Unfortunately for me, unlike git or mercurial, darcs is using a _darcs directory to hold all repo data, and kdevelop is filtering only hidden files (ie. those starting with a dot), so the Quick open was rendered useless as it listed tons of _darcs/something files that I certainly didn't want to edit by hand.
> 
> That's why I patched kdevelop to filter out _darcs directories. I simply added additional if in the cmakemanager.cpp file into the filterFiles function (it filtered only backup files).
> 
> I realize this cannot be a top priority to merge, but since it is an extremely minor fix, I hope you'll integrate it into kdevelop anyways.
> 
> Best regards,
> Filip
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/cmakemanager.cpp 7fd75da 
> 
> Diff: http://git.reviewboard.kde.org/r/103549/diff/diff
> 
> 
> Testing
> -------
> 
> I've compiled kdevelop with this patch on Gentoo (4.2.2 is currently stable Gentoo version, but the patch is from git tip) and now it successfully filters out _darcs directories rendering quickopen usable again.
> 
> 
> Thanks,
> 
> Filip Brcic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111227/0029b8b9/attachment.html>