Review Request: patch to add support for C++11 user defined string literals to kdevelop background parser

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103485/#review9217
-----------------------------------------------------------


Please fix the two issues below, and then before this can be merged we need:

a) some comment in the lexer to explain what this code does (i.e. user-defined string literals)
b) unit tests, this is crucial - without at least a few tests, this cannot be merged.

thanks


kdevelop.kdev4
<http://git.reviewboard.kde.org/r/103485/#comment7635>

    unrelated change, please remove this hunk from this patch



languages/cpp/parser/lexer.cpp
<http://git.reviewboard.kde.org/r/103485/#comment7636>

    I don't like this error message, please be more descriptive or better yet, copy the error message from an existing compiler which already supports this feature


- Milian Wolff


On Dec. 21, 2011, noon, François-Marie de Jouvencel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103485/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, noon)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This is to add support for C++11 user defined string literals (that is, strings like "hello"_world) to the kdevelop background parser. The patch consists of just a few lines in lexer.cpp.
> 
> 
> Diffs
> -----
> 
>   kdevelop.kdev4 023bd89 
>   languages/cpp/parser/lexer.cpp 755b5ab 
> 
> Diff: http://git.reviewboard.kde.org/r/103485/diff/diff
> 
> 
> Testing
> -------
> 
> I have been using the patch since a day or two and I did not notice anything broken.
> 
> 
> Thanks,
> 
> François-Marie de Jouvencel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111223/e711530f/attachment.html>