Review Request: Fix reopening of areas when kdevelop was closed with some splitted views

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103501/#review9187
-----------------------------------------------------------


This review has been submitted with commit f450780912f925edffd46efb21e01ea8656d9c9e by Lambert CLARA to branch 1.3.

- Commit Hook


On Dec. 22, 2011, 8:16 a.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103501/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2011, 8:16 a.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> When kdevelop is closed having a splitted view, the next reopening creates a "gray" widget in the middle of the mainwindow. Closing the tabs afterwards may lead to a crash.
> 
> The method cleanCentralWidget was iterating through the mainwindow splitter's content with a 'for' loop to delete the widgets inside, but this cannot work because each "delete" of a widget changes the count().
> A simple 'while' loop instead fixes it.
> 
> I don't think there is an opened bug for this, shoud I open one ?
> 
> 
> Diffs
> -----
> 
>   sublime/mainwindow_p.cpp 61f4804 
> 
> Diff: http://git.reviewboard.kde.org/r/103501/diff/diff
> 
> 
> Testing
> -------
> 
> Split views, change areas from debug/code, close and reopen kdevelop and check if all is reloaded correctly.
> 
> 
> Thanks,
> 
> Lambert CLARA
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111222/cc0b5e77/attachment.html>