Review Request: Fix reopening of areas when kdevelop was closed with some splitted views

Lambert CLARA lambert.clara at yahoo.fr
Thu Dec 22 08:16:11 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103501/
-----------------------------------------------------------

Review request for KDevelop and Aleix Pol Gonzalez.


Description
-------

When kdevelop is closed having a splitted view, the next reopening creates a "gray" widget in the middle of the mainwindow. Closing the tabs afterwards may lead to a crash.

The method cleanCentralWidget was iterating through the mainwindow splitter's content with a 'for' loop to delete the widgets inside, but this cannot work because each "delete" of a widget changes the count().
A simple 'while' loop instead fixes it.

I don't think there is an opened bug for this, shoud I open one ?


Diffs
-----

  sublime/mainwindow_p.cpp 61f4804 

Diff: http://git.reviewboard.kde.org/r/103501/diff/diff


Testing
-------

Split views, change areas from debug/code, close and reopen kdevelop and check if all is reloaded correctly.


Thanks,

Lambert CLARA

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111222/875db306/attachment.html>


More information about the KDevelop-devel mailing list