Review Request: Parser support for C99 designated initializers

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103448/#review9092
-----------------------------------------------------------



languages/cpp/parser/parser.cpp
<http://git.reviewboard.kde.org/r/103448/#comment7518>

    this is bad, as it is *not* valid c++, see
    
    http://www.nongnu.org/hcb/#initializer-list
    
    please pass the mimetype along or find it again (in a fast way, I think the language controller can do that) to find out whether you are in "c" or in "c++" mode and decide based on that.



languages/cpp/parser/parser.cpp
<http://git.reviewboard.kde.org/r/103448/#comment7519>

    was the change in order intentional? I'd rather have the parseDesignatedInitializer as last resort, as it will not occur in most code (as it's a C feature and we are currently mostly aiming at c++)


- Milian Wolff


On Dec. 18, 2011, 12:23 p.m., Alexandre Courbot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103448/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2011, 12:23 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Description
> -------
> 
> Parser support for C99 designated initializers
> 
> Support C99 initializers in the C++ parser, e.g:
> 
> struct foo_t foo = {
>   .has_cake = true,
>   .nb_candles = 12,
> };
> 
> int bar[10] = {
>   [1] = 15,
>   [9] = 25,
> };
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/parser.h ffc3967e9bec09ff56204aab98e8f80ec6b036cf 
>   languages/cpp/parser/parser.cpp 1c9d9e403500f35761ebc6deb737a4a68a53c28d 
>   languages/cpp/parser/tests/test_parser.h fa92f1ce284df0936724f74f42f9ad6d4b3c97fc 
>   languages/cpp/parser/tests/test_parser.cpp f747cfa44bdf962be33cf97841fdae739b3e1771 
> 
> Diff: http://git.reviewboard.kde.org/r/103448/diff/diff
> 
> 
> Testing
> -------
> 
> Used it for a couple of weeks, ensured the parser tests all pass.
> 
> 
> Thanks,
> 
> Alexandre Courbot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111219/62ade22a/attachment.html>