Encoding of Generated Patches and Pastebin Plugin

[David Narvaez]

Hi,

Before I start, I'd like to say I hate encoding issues...

I was trying out the Pastebin plugin for the patches I sent recently
and I (very) accidentally noticed it has encoding issues. I tracked
the issue down the following patch, which solves my particular test
case:

-    QByteArray bytearray =
"paste_code="+QUrl::toPercentEncoding(urlToData(source->file()), "/");
+    QByteArray bytearray =
"paste_code="+QUrl::toPercentEncoding(QString::fromUtf8(urlToData(source->file())),
"/");

that assumes the source of the patch review is in UTF-8, but I guess
we can't assure that, right? Does anybody knows if there's any way to
guarantee all files created for patch review are stored UTF-8 (or any
other encoding as long as it is uniform)? Could that be something
governed by user settings which we can query?


David E. Narváez