Review Request: Fix compiling the Okteta plugin with the libs of the upcoming Okteta v0.8
Friedrich W. H. Kossebau
kossebau at kde.org
Sun Dec 18 20:59:33 UTC 2011
> On Dec. 13, 2011, 6:07 p.m., Milian Wolff wrote:
> > Ship It!
>
> Friedrich W. H. Kossebau wrote:
> Okay to also backport to 1.2 ?
At least it does not hurt to backport to 1.2, so doing now.
- Friedrich W. H.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103397/#review8931
-----------------------------------------------------------
On Dec. 12, 2011, 8:10 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103397/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2011, 8:10 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> The Kasten/Okteta libs of the upcoming Okteta v0.8 have a versioned namespace, the Okteta plugin will not be compiled with those libs ATM.
>
> Attached patch changes that, and will compile with whatever version there is.
>
>
> Diffs
> -----
>
> cmake/modules/FindLibKasten.cmake 573782b
> cmake/modules/FindLibOkteta.cmake 6371c11
> cmake/modules/FindLibOktetaKasten.cmake f641fe1
> utils/CMakeLists.txt 822683d
> utils/okteta/CMakeLists.txt 66bf8b5
> utils/okteta/kastentoolviewwidget.h 3a5fd7e
> utils/okteta/kastentoolviewwidget.cpp c69a395
> utils/okteta/oktetadocument.h aba0996
> utils/okteta/oktetadocument.cpp cbe41e8
> utils/okteta/oktetatoolviewfactory.h ddc7770
> utils/okteta/oktetatoolviewfactory.cpp a483f5c
> utils/okteta/oktetaview.h 9dad1ea
> utils/okteta/oktetawidget.h dac83cf
>
> Diff: http://git.reviewboard.kde.org/r/103397/diff/diff
>
>
> Testing
> -------
>
> Works for me, both with the old libs/headers installed and/or with the new libs/headers installed or none at all.
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111218/38dadf5e/attachment.html>
More information about the KDevelop-devel
mailing list