Review Request: Parser support for C99 designated initializers

[Alexandre Courbot]

> On Dec. 18, 2011, 12:42 p.m., Steffen Ohrendorf wrote:
> > languages/cpp/parser/tests/test_parser.h, line 89
> > <http://git.reviewboard.kde.org/r/103448/diff/1/?file=43721#file43721line89>
> >
> >     I'm not sure that C99 support should go into the C++ parser.

Where else? The C++ parser is currently rather a C/C++ one. KDevelop does not have separate support for C, so until this is available I do not see where this could go.


> On Dec. 18, 2011, 12:42 p.m., Steffen Ohrendorf wrote:
> > languages/cpp/parser/parser.cpp, line 2834
> > <http://git.reviewboard.kde.org/r/103448/diff/1/?file=43720#file43720line2834>
> >
> >     try to avoid gotos

This makes error handling easier here. Not sure whether we need to rewind here or if a simple return would be enough - I have seen both through the code but could not figure out when each pattern should be used.


- Alexandre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103448/#review9037
-----------------------------------------------------------


On Dec. 18, 2011, 12:23 p.m., Alexandre Courbot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103448/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2011, 12:23 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Description
> -------
> 
> Parser support for C99 designated initializers
> 
> Support C99 initializers in the C++ parser, e.g:
> 
> struct foo_t foo = {
>   .has_cake = true,
>   .nb_candles = 12,
> };
> 
> int bar[10] = {
>   [1] = 15,
>   [9] = 25,
> };
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/parser.h ffc3967e9bec09ff56204aab98e8f80ec6b036cf 
>   languages/cpp/parser/parser.cpp 1c9d9e403500f35761ebc6deb737a4a68a53c28d 
>   languages/cpp/parser/tests/test_parser.h fa92f1ce284df0936724f74f42f9ad6d4b3c97fc 
>   languages/cpp/parser/tests/test_parser.cpp f747cfa44bdf962be33cf97841fdae739b3e1771 
> 
> Diff: http://git.reviewboard.kde.org/r/103448/diff/diff
> 
> 
> Testing
> -------
> 
> Used it for a couple of weeks, ensured the parser tests all pass.
> 
> 
> Thanks,
> 
> Alexandre Courbot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111218/d0af6bf3/attachment.html>