Review Request: Fix compiling of quanta master

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103386/#review8907
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Dec. 11, 2011, 7:09 p.m., Florian Zumkeller-Quast wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103386/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2011, 7:09 p.m.)
> 
> 
> Review request for KDevelop and Quanta.
> 
> 
> Description
> -------
> 
> Since the last changes of ISourceFormatter from KDevPlatform Quanta was broken and did not compile.
> This patch fixes the compiling issues by changing phpformatterplugin and xmlformatterplugin to the new interface of ISourceFormatter.
> 
> During the testing it looked to me that there are two different options storing the indentation value for a formatter:
> "INDENT" and "indent_size". Because only the latter contained a non-zero value, i changed the behaviour to use the latter one.
> 
> 
> Diffs
> -----
> 
>   languages/xml/formatter/formatterplugin.h dbe183a 
>   languages/xml/formatter/formatterplugin.cpp 4e62a1e 
>   plugins/phpformatter/formatterplugin.h 6dc7028 
>   plugins/phpformatter/formatterplugin.cpp f1ca6fd 
> 
> Diff: http://git.reviewboard.kde.org/r/103386/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Florian Zumkeller-Quast
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111213/529acbb4/attachment.html>