Review Request: Replace Projects QComboBox by Filtered QListView in KDE Provider

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103383/#review8877
-----------------------------------------------------------



providers/kdeprovider/kdeproviderwidget.cpp
<http://git.reviewboard.kde.org/r/103383/#comment7402>

    This shouldn't be needed, if it is it means that we let the user to select, nothing, which is bad UI-wise.



providers/kdeprovider/kdeproviderwidget.cpp
<http://git.reviewboard.kde.org/r/103383/#comment7400>

    add const& to the argument



providers/kdeprovider/kdeproviderwidget.cpp
<http://git.reviewboard.kde.org/r/103383/#comment7401>

    Is it really possible that the index is not valid? Doesn't look like it...


All in all I think it's good, I'd like to see less gray space in the UI though. What about moving the "Settings" by the filter?
Maybe you can store last used projects in the filter.

I think that the combo box worked fine. If it doesn't fit and we want to improve further, we have to do it thoroughly.

- Aleix Pol Gonzalez


On Dec. 11, 2011, 7:29 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103383/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2011, 7:29 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This proposal is very similar to review 103187, it should help developers find projects faster.
> 
> 
> Diffs
> -----
> 
>   providers/kdeprovider/kdeproviderwidget.h 8025638 
>   providers/kdeprovider/kdeproviderwidget.cpp eb84faf 
> 
> Diff: http://git.reviewboard.kde.org/r/103383/diff/diff
> 
> 
> Testing
> -------
> 
> Fetched Amarok from the KDE Provider. See new UI in attached image.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111211/4c7ef5a7/attachment.html>