Review Request: Properly Connect Protocol Config Widget in KDE Provider

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103185/#review8816
-----------------------------------------------------------

Ship it!


Good :) please push!

sorry for forgetting! >.<

- Aleix Pol Gonzalez


On Nov. 19, 2011, 2:12 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103185/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2011, 2:12 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Changing the name of the widget allows it to connect to the gitProtocol configuration setting. Also added the kcfg_property property to avoid issues with the QComboBox value.
> 
> 
> Diffs
> -----
> 
>   providers/kdeprovider/kdeconfig.ui c3f17a7 
>   providers/kdeprovider/kdeproviderwidget.cpp 3467afb 
> 
> Diff: http://git.reviewboard.kde.org/r/103185/diff/diff
> 
> 
> Testing
> -------
> 
> 1. Open/Fetch Project...
> 2. Select the KDE Provider
> 3. Click on the Settings button next to the Project selection Combo Box
> 4. Switch to HTTP or SSH
> 5. Fetch the project
> 
> Before this patch, the fetching URL would always be http://anongit.kde.org (default for git protocol). This patch enables fetching from http and ssh too.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111209/c0e37408/attachment.html>