Review Request: Fix broken create new from template feature

Milian Wolff mail at milianw.de
Sat Aug 27 16:05:20 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102455/#review6064
-----------------------------------------------------------

Ship it!


looks good if it solves the problem but wait for a review of aleix as he broke it apparently :)

- Milian


On Aug. 27, 2011, 1:01 p.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102455/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2011, 1:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Currently create new project from template doesn't work on master. Lokks like it's broken by 24356dd7defdbf96bca56707a28906bee613628f. This patch fixes the problem.
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/projectselectionpage.h fedbb80 
>   plugins/appwizard/projectselectionpage.cpp 5f82cc8 
> 
> Diff: http://git.reviewboard.kde.org/r/102455/diff
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110827/e4ed9269/attachment.html>


More information about the KDevelop-devel mailing list