Code completion locking

Milian Wolff mail at milianw.de
Sat Aug 27 02:05:54 UTC 2011


On Saturday 27 August 2011 04:05:20 Milian Wolff wrote:
> On Wednesday 17 August 2011 14:24:28 Olivier JG wrote:
> > I've refactored the CPP code completion context a bit as well as
> > reorganized the locking it does. This should fix the occasional deadlock
> > during "case |" completion.
> > However, I also made a change to kdevplatform so that the duchain is no
> > longer locked when calling "completionItems()", since that makes it
> > impossible to later acquire the foregroundlock. If any other languages
> > (PHP, Python) rely on that, they'll need to acquire the lock themselves.
> > Let me know if this is a problem for any reason, or if I screwed
> > something up.
> > 
> > Please everyone also get a backtrace if you deadlock during code
> > completion, as it's probably my fault (even though I thought I thought
> > it through pretty well). I'll fix it quickly.
> 
> This looks like introduced by this change:
> 
> https://bugs.kde.org/show_bug.cgi?id=280401
> 
> Can you take a look at it?

zomg nvm - this is 4.2.2 which of course does not have your patch :-/

/me needs to go to bed
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110827/40962fa0/attachment.sig>


More information about the KDevelop-devel mailing list