Regarding commit 049175604 (fix compile with QT_USE_FAST_CONCATENATION....)

Milian Wolff mail at
Thu Aug 11 14:14:55 UTC 2011

CC'ing Montel, not sure whether he reads kdevelop-devel.

David Nolden, 11.08.2011:
> I think this makes the code uglier, without any gain. All of the
> changed code-locations are not performance relevant.
> Basically all the changes are:
> myString + "myText"
> ->
> QString(myString + "myText")
> Which is the opposite of natural. So why do this?

I agree, couldn't we use % instead of +:

This should make the QString() wrapper obsolete, no?


Milian Wolff
mail at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <>

More information about the KDevelop-devel mailing list