Regarding commit 049175604 (fix compile with QT_USE_FAST_CONCATENATION....)

[Milian Wolff]

CC'ing Montel, not sure whether he reads kdevelop-devel.

David Nolden, 11.08.2011:
> I think this makes the code uglier, without any gain. All of the
> changed code-locations are not performance relevant.
> 
> Basically all the changes are:
> 
> myString + "myText"
> ->
> QString(myString + "myText")
> 
> Which is the opposite of natural. So why do this?

I agree, couldn't we use % instead of +:

http://developer.qt.nokia.com/wiki/UsingQStringEffectively#6c7f5f5135b4092d900571aab77097fd

This should make the QString() wrapper obsolete, no?

bye

-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110811/3b3235ac/attachment.sig>