Regarding commit 049175604 (fix compile with QT_USE_FAST_CONCATENATION....)

Aleix Pol aleixpol at kde.org
Thu Aug 11 14:13:26 UTC 2011


On Thu, Aug 11, 2011 at 4:05 PM, David Nolden <zwabel at googlemail.com> wrote:

> I think this makes the code uglier, without any gain. All of the
> changed code-locations are not performance relevant.
>
> Basically all the changes are:
>
> myString + "myText"
> ->
> QString(myString + "myText")
>
> Which is the opposite of natural. So why do this?
>
> --
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>

That happens because with this change + returns a QStringBuilder.

It makes string concatenation to work much faster so I think it's a good
trade off.

Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110811/b0d53ce0/attachment.html>


More information about the KDevelop-devel mailing list