Review Request: Introduce/integrate VcsFileChangesModel

Aleix Pol Gonzalez aleixpol at gmail.com
Mon Apr 18 17:20:29 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101145/#review2731
-----------------------------------------------------------

Ship it!


Nice :)

- Aleix


On April 17, 2011, 1:24 a.m., Andrey Batyiev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101145/
> -----------------------------------------------------------
> 
> (Updated April 17, 2011, 1:24 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> In this patch model class from Aleix vcsprojectintegration plugins is merge into KDevelop with PatchReview and VcsCommitDialog.
> Advantages:
> 1. less individual code, more shared code, better maintaince
> 2. unified look and feel
> 3. unit-tests
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/CMakeLists.txt 222e28f 
>   plugins/patchreview/patchreview.h eb0bc38 
>   plugins/patchreview/patchreview.cpp 2811869 
>   plugins/patchreview/patchreview.ui 8fe9cd1 
>   vcs/CMakeLists.txt f3cd726 
>   vcs/models/tests/CMakeLists.txt PRE-CREATION 
>   vcs/models/tests/modelstest.h PRE-CREATION 
>   vcs/models/tests/modelstest.cpp PRE-CREATION 
>   vcs/models/vcsfilechangesmodel.h PRE-CREATION 
>   vcs/models/vcsfilechangesmodel.cpp PRE-CREATION 
>   vcs/widgets/vcscommitdialog.cpp fca9e94 
>   vcs/widgets/vcscommitdialog.ui 5f09c95 
> 
> Diff: http://git.reviewboard.kde.org/r/101145/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110418/9e580012/attachment.html>


More information about the KDevelop-devel mailing list