Review Request: Implement "go to file:line" in quickopen

[Dmitry Risenberg]

> On April 8, 2011, 1:01 p.m., David Nolden wrote:
> > Look OK, very useful and nice feature.
> > However, I think it would be better if this was implemented "upstream" within IOpenWith and/or DocumentController::openDocument(..), so that it would also work with command-line arguments and such. In theory, it is also possible to have colons in filenames, so one would first have to make sure that the filename including the colon does not exist.

Looks like it can't be done upstream cleanly, because *DataProvider use stored data, not input text, to open files. So the only thing worth moving upstream is extractLineNumber.


- Dmitry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101054/#review2494
-----------------------------------------------------------


On April 7, 2011, 9:02 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101054/
> -----------------------------------------------------------
> 
> (Updated April 7, 2011, 9:02 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Make quickopen able to parse strings formatted to "path to file":"line number" template. When a ProjectFileData item is executed, go to line "line number" after opening the file.
> 
> Also export the template parsing function to be used in kdevelop.
> 
> See also https://git.reviewboard.kde.org/r/101055/ for changes in kdevelop.
> 
> 
> This addresses bug 165593.
>     http://bugs.kde.org/show_bug.cgi?id=165593
> 
> 
> Diffs
> -----
> 
>   language/interfaces/quickopendataprovider.h d3dd5f2b031fdc40b92ff76e582e6bd8aa964835 
>   language/interfaces/quickopendataprovider.cpp 5cf185e34678f860af09671acd1411353586320f 
>   plugins/quickopen/projectfilequickopen.cpp 496f8d328d0619d5014f91a20fa9753bd863daab 
> 
> Diff: http://git.reviewboard.kde.org/r/101054/diff
> 
> 
> Testing
> -------
> 
> Manual.
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110410/e3745048/attachment.html>