Review Request: Cleanup PatchReview plugin

[Andrey Batyiev]

> On April 7, 2011, 4:47 p.m., Milian Wolff wrote:
> > looks fine, have you checked git annotate to see why the signal blocking is there? maybe there was/is a reason?

It appears in first revision of PatchReview plugin, put around insertion of toplevel items in QTreeView of files state. Now, that insertion is moved/altered and block-unblock sequence no more needed.


- Andrey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101040/#review2465
-----------------------------------------------------------


On April 6, 2011, 6:04 p.m., Andrey Batyiev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101040/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 6:04 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> 1. blockedSignals return previous state of signal block. removing code that essentially does nothing.
> 2. Move qRegisterMetaType to PatchReviewPlugin constructor - no need to re-register type on every new patch loaded.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreview.cpp d546e10 
> 
> Diff: http://git.reviewboard.kde.org/r/101040/diff
> 
> 
> Testing
> -------
> 
> Manual.
> 
> 
> Thanks,
> 
> Andrey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110407/b4053b8d/attachment.html>