Review Request: Cleanup PatchReview plugin

Andrey Batyiev batyiev at gmail.com
Wed Apr 6 18:04:05 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101040/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

1. blockedSignals return previous state of signal block. removing code that essentially does nothing.
2. Move qRegisterMetaType to PatchReviewPlugin constructor - no need to re-register type on every new patch loaded.


Diffs
-----

  plugins/patchreview/patchreview.cpp d546e10 

Diff: http://git.reviewboard.kde.org/r/101040/diff


Testing
-------

Manual.


Thanks,

Andrey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110406/ee9955c8/attachment.html>


More information about the KDevelop-devel mailing list