Review Request: Automatically resize VariableTooltip to fit its contents

Dmitry Risenberg dmitry.risenberg at gmail.com
Sun Apr 3 20:39:30 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101021/
-----------------------------------------------------------

(Updated April 3, 2011, 8:39 p.m.)


Review request for KDevelop.


Changes
-------

Maximum tooltip width set to 3/4 of screen width. Also make left and top of tooltip always fit the screen.


Summary
-------

When debug tooltip displays long names/values, I have to manually resize it to see all the info. This patch changes debug tooltip behaviour to automatically resize itself when items are expanded.

Also requires a small patch to kdevelop:

diff --git a/debuggers/gdb/gdbvariable.cpp b/debuggers/gdb/gdbvariable.cpp
index ae65169..cab25a2 100644
--- a/debuggers/gdb/gdbvariable.cpp
+++ b/debuggers/gdb/gdbvariable.cpp
@@ -223,6 +223,7 @@ public:
 
         variable->setHasMore(hasMore);
         if (m_activeCommands == 0) {
+            variable->emitAllChildrenFetched();
             delete this;
         }
     }

P.S. Should this go to 4.2 or master?


Diffs (updated)
-----

  debugger/util/treeitem.h 94cd6dbc38d2ecdaaec2f7185201c00031752efd 
  debugger/util/treeitem.cpp 7e0f6bc3c6eb70f31f1ae72d47610a58731f8cad 
  debugger/util/treemodel.h e12e0161ba375526fb2cfe40ec166be4f332c448 
  debugger/util/treemodel.cpp 6d53cb8776e54212e48e95690052eb007c69d03c 
  debugger/util/treeview.h b0e32709a96732f404eb8ea587858536086527a0 
  debugger/util/treeview.cpp 72f5567b73eea3e9fe4a72ced91882a0ce5be549 
  debugger/variable/variabletooltip.cpp 1c3c537ccdd788aa4a3b4fcc0edd70fd121b2816 
  util/activetooltip.cpp 377843f6b0f37bb6b54d31038de6641b1f12bc6c 

Diff: http://git.reviewboard.kde.org/r/101021/diff


Testing
-------

Manual


Thanks,

Dmitry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110403/05518844/attachment.html>


More information about the KDevelop-devel mailing list