Review Request: Use KStandardAction::fullScreen() in KDevelop::MainWindow.

Parker Coates parker.coates at kdemail.net
Fri Apr 1 21:49:53 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101009/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

Use KStandardAction::fullScreen() to "Full Screen Mode" action. This is less code AND makes KDevelop use the "standard" full screen shortcut, Ctrl+Shift+F. It is currently using Ctrl+Shift+F11.

As far as I can tell, there was no particular reason why the action was given a custom implementation. See http://commits.kde.org/kdevplatform/c7540f .


Diffs
-----

  shell/mainwindow_p.cpp c158b72 

Diff: http://git.reviewboard.kde.org/r/101009/diff


Testing
-------

Tested my KDevelop master installation. Everything seems to work as before.


Thanks,

Parker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110401/73cbb1b8/attachment.html>


More information about the KDevelop-devel mailing list